Fork Jasmine #3147
Merged
Fork Jasmine #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
aaronabramov
approved these changes
Mar 15, 2017
packages/jest-jasmine2/src/index.js
Outdated
| displayErrors: true, | ||
| filename: JASMINE_PATH, | ||
| }); | ||
| const JASMINE_PATH = require.resolve('./jasmine-2.5.2.js'); |
There was a problem hiding this comment.
i think at this point we can just call it jasmine and strip 2.5.2
| }; | ||
|
|
||
| exports.version = function() { | ||
| return '2.5.2-custom'; |
|
Let's do it then. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Remove unused and unsupported Jasmine features. * Move jasmine to src. * Jasmine is now a beautiful piece of pretty printed code. * Fix up stack trace filtering. * Lint fixes. * More dead code removal. * Call it jasmine-light.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Remove unused and unsupported Jasmine features. * Move jasmine to src. * Jasmine is now a beautiful piece of pretty printed code. * Fix up stack trace filtering. * Lint fixes. * More dead code removal. * Call it jasmine-light.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff removes half of Jasmine's implementation, cleans up the project by pretty-printing it and fixes all lint errors. For the longest time we've had our own fork of Jasmine. Updating Jasmine, even though it is still maintained, doesn't really provide us any value. It is only a tiny part of the Jest testing platform and we aren't using many features of it. Our plan has been to replace Jasmine but realistically the only way this is going to happen is if we rewrite our test-runner in place without breaking changes. This diff is not the first step: over the last year we have incrementally been doing exactly this. We built our own assertion library, asymmetric matchers and spies. This is simply the next step. The remaining pieces of Jasmine are now basically only the actual spec runner and the reporter API. Once we have async reporters (cc @DmitriiAbramov) we can remove Jasmine's reporters entirely and build an adapter API.
Changes:
Removed Features:
Test plan
yarn test
Next Steps (volunteers welcome)
jest-mock(jest.spyOn etc.) and remove Jasmine's spy system.diaf